Add RTSP VP8 Reader test #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialise fragmentedSampleSizeBytes with 0, instead of UNSET since we directly add sample size to it. Change-Id: I9d5735422a4a0eeb2967af93809b879b434e3c57
Update VP8 Reader to handle missing frames/fragments. Change-Id: I9eede8f1e3a20fb0ff2e7add0dfc60f0780ec769
|
A general question before start reviewing: why there are changes to the VP8 reader? Is it adding new feature, or is it a bug fix? |
|
Fix VP8 Reader commit is a bug fix. And we have added the test as a separate commit. |
|
In that case can you share some details on what the bug is in writing?
…On Fri, Jul 1, 2022 at 11:11 AM Shraddha Basantwani < ***@***.***> wrote:
Fix VP8 Reader commit
<b5da5f0>
is a bug fix. And we have added the test as a separate commit.
—
Reply to this email directly, view it on GitHub
<#101 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUCMUUURWINKT37FQPG5VZLVR275PANCNFSM52ID5FWA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Created a new PR, abandoning this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.