strict matching of segment boundary #2826
Open
+108
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is spawned from #2484 (comment)
summary:
at
media/libraries/exoplayer_hls/src/main/java/androidx/media3/exoplayer/hls/HlsInterstitialsAdsLoader.java
Lines 1524 to 1527 in d0e4133
using
mediaPlaylist.targetDurationUs
can lead to identifying the wrong index as it's not guranteed that all segments will match the target duration. Especially around interstitial boundaries it's happens often that the actual segment duration is vastly different. This happening a lot of time in a stream can lead to identifying the wrong target segment.The proposed solution instead looks at the actual segment duration to find the best match.
I went with a binary search to try and improve performance for long streams. Our live sliding window streams have more than 1500 segments per playlist.