Skip to content

equals(Object obj)" and "hashCode()" should be overridden in pairs #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

equals(Object obj)" and "hashCode()" should be overridden in pairs #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/tern.core/src/tern/server/TernModuleInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,15 @@ public boolean equals(Object o) {
return false;
}

@Override
public int hashCode() {
int result = super.hashCode();
result = 31 * result + (name != null ? name.hashCode() : 0);
result = 31 * result + (type != null ? type.hashCode() : 0);
result = 31 * result + (version != null ? version.hashCode() : 0);
return result;
}

private boolean equals(Object o1, Object o2) {
if (o1 == null) {
return (o2 == null);
Expand Down
7 changes: 7 additions & 0 deletions eclipse/tern.eclipse.ide.core/src/tern/eclipse/ide/core/resources/TernDocumentFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,11 @@ public boolean equals(Object obj) {
TernDocumentFile doc = (TernDocumentFile) obj;
return doc.document.equals(this.document) && doc.getFile().equals(getFile());
}

@Override
public int hashCode() {
int result = super.hashCode();
result = 31 * result + (document != null ? document.hashCode() : 0);
return result;
}
}
13 changes: 13 additions & 0 deletions ...se/tern.eclipse.ide.core/src/tern/eclipse/ide/internal/core/resources/IDETernProject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,19 @@ public boolean equals(Object value) {
return super.equals(value);
}

@Override
public int hashCode() {
int result = super.hashCode();
result = 31 * result + (project != null ? project.hashCode() : 0);
result = 31 * result + (ternServer != null ? ternServer.hashCode() : 0);
result = 31 * result + (scriptPaths != null ? scriptPaths.hashCode() : 0);
result = 31 * result + (sortedScriptPaths != null ? sortedScriptPaths.hashCode() : 0);
result = 31 * result + (data != null ? data.hashCode() : 0);
result = 31 * result + (listeners != null ? listeners.hashCode() : 0);
result = 31 * result + (workingCopy != null ? workingCopy.hashCode() : 0);
return result;
}

/**
* Returns the script path instance from the given path and null otherwise.
*
Expand Down