Infinite scroll needLoadMoreDataTop works weird (or how should that work)

[jcompagner]

first if you go to the example:

http://ui-grid.info/docs/#/tutorial/212_infinite_scroll

and you do 1 click down, (so scroll only 1 row)
then 1 up again you see suddenly a completely different list. This is quite weird and brings to my question how shoiuld needLoadMoreDataTop really work?

Because if you start from the top then all the data is already there on the top.. Its not that suddenly you need to fill a row thats on a negative index

Or is this feature for that if you would start somewhere in the middle? in the first place? But then the start is just wrong, because you first have to scroll a bit down to be able to fill it up. thats just bad ui.

besides that you need to really supply neadLoadMoreDataTop because if you don't do that:

http://plnkr.co/edit/56DNHGw1FHQFF5HtpGhL?p=preview

then if you click once down, then one time up (so that it would have triggered dataTop once) then suddenly the whole needLoadMore is broken because the timeout stays on true...

so i need to always add a dummy function that just does:

gridApi.infiniteScroll.on.needLoadMoreDataTop($scope,function(){
$scope.gridApi.infiniteScroll.dataLoaded();
});

because that will set the: grid.options.loadTimout = false;

so it works the next time i scroll. But again i have no idea what to really do in that method otherwise.

If infinite scroll would really be some kind of "page" so that the needMoreData (top) did get more arguments so i know exactly what the view port should be (or become)
then i could delete rows at the top and cleanup my stuff
Then needMoreDatatop would load that data back in.
Problem is that then the scrollbar will not work i guess because for a ui-grid point of view if i would delete data on the top the total rows would just be smaller.

[PaulL1]

I made some substantial changes to infinite scroll the other day that should probably address this. They're committed to master, but don't appear to have come through to the tutorials and unstable. You could perhaps check out master and see whether they resolve this issue.

[PaulL1]

These changes are now in the tutorial.

[jcompagner]

i am testing the tutorials and yes it works now way better and more natural (still a bit weird but at least you can now click directly that you want to go up and it goes up then)

But i guess for people that want to start "in the middle" you can do that now.

the thing that is still "broken" in my eyes is that if you disable (in the infinite scroll example)

/gridApi.infiniteScroll.on.needLoadMoreDataTop($scope, $scope.getDataUp);

that line so you don't configure needLoadMoreDataTop (because i am really not interessted to that)
then scroll down also breaks if you scrolled up once..

[PaulL1]

If you don't want to scroll up, then you would now set gridOptions.infiniteScrollUp to false.

[jcompagner]

but that isn't default somehow?

http://plnkr.co/edit/0GkLNV8QczMVja7NzxfC?p=preview

i deleted that gridOptions.infiniteScrollUp : true line and the needLoadMoreDataTop
but still that breaks scrolling.

why do we have now those properties? because what happens if i don't specify the infiniteScrollDown but i do specify the gridApi.infiniteScroll.on.needLoadMoreData($scope, $scope.getDataDown);

or the other way around?

this should in my eyes just be 1 thing. that property can be set when needLoadMoreData is called.

[PaulL1]

That plunker doesn't run.

The issue is that if you delete the infiniteScrollUp, you also need to always provide false to that parameter in the dataLoaded call. If you leave those calls alone, then next time you provide data down, it will re-enable the scroll up.

[jcompagner]

weird that the plunker doesn't run, for me it runs fine

http://plnkr.co/edit/0GkLNV8QczMVja7NzxfC?p=preview

the thing i am trying to say is that we have no 2 booleans or configuration options that you have to use both and they have to be in sync.

if i use the plunker and i scroll down then that works fine
but if i have scrolled up once (completely to the top) and then down again then it is broken

the plunker is just this: http://ui-grid.info/docs/#/tutorial/212_infinite_scroll

but then 2 lines deleted:

infiniteScrollUp: true,
gridApi.infiniteScroll.on.needLoadMoreDataTop($scope, $scope.getDataUp);

in the code

then it just breaks, but i don't want scrollUP i don't want to be forced to configured it or call it.

[PaulL1]

If you leave it out, then you need to:

1. when you call dataLoaded you always provide false to the scrollUp property
2. remove the logic that deletes spare pages of data - that logic will re-enable scrollUp

Refer http://plnkr.co/edit/0GkLNV8QczMVja7NzxfC?p=preview

[TizeShrey]

Refer http://plnkr.co/edit/0GkLNV8QczMVja7NzxfC?p=preview
This plnkr won't pull records on getDataDown. Since you have removed infiniteScrollUp, it's supposed to work downwards or am I missing something ? It's just a static list of 100 records now.