Skip to content

Conversation

@jmsunseri
Copy link
Contributor

I added a new option exporterMenuItemOrder for the gridOptions so that I could adjust where the items were showing up in the menu.

I added a new option exporterMenuItemOrder for the gridOptions so that I could adjust where the menu items were showing up in the grid
@jmsunseri
Copy link
Contributor Author

Do I need to modify the tests as well?

adding to the tests to make sure when set to default number and when set to non default number the option still works
@jmsunseri
Copy link
Contributor Author

I updated the test and am submitting a new pull request

@jmsunseri
Copy link
Contributor Author

Ok, I'm not sure what this failure indicates. Please advise.

@imbalind
Copy link
Contributor

This is not an error related to your code, no actions are needed by you. We will fix it soon.

@jmsunseri
Copy link
Contributor Author

Thanks!
On Nov 11, 2015 1:25 AM, "Matteo Brassini" [email protected] wrote:

This is not an error related to your code, no actions are needed by you.
We will fix it soon.


Reply to this email directly or view it on GitHub
#4671 (comment).

@jmsunseri
Copy link
Contributor Author

Has this still not been merged in?

@dlgski dlgski merged commit 34a7ac6 into angular-ui:master Nov 8, 2016
@jmsunseri
Copy link
Contributor Author

My first contribution to an open source project finally had been accepted!

On Nov 8, 2016 6:38 AM, "dlgski" [email protected] wrote:

Merged #4671 #4671.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4671 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxHl291WRZya9R_qMTzS0IMG9b3QnGpks5q8G1fgaJpZM4Gf3OA
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants