Fix#4658 #5762
Merged
Fix#4658 #5762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 20, 2016 13:03
Added icon definitions into icons.less and removed fontello from build process angular-ui#4658
mportuga
approved these changes
Nov 7, 2016
goblinbr
pushed a commit
to kugel-soft/ui-grid
that referenced
this pull request
May 24, 2018
* Fixes angular-ui#3832 * chore(less): Propose fix for angular-ui#4658 Added icon definitions into icons.less and removed fontello from build process angular-ui#4658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Since they've stabilized quite a bit, the less could probably be used statically rather than generating it as part of the build."
Did just that. Icons now statically defined in icons.less