-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Bootstrap4 template choices.tpl.html #2074
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up dist folder before review
|
Can someone help review and merge the pull request? By the way, I tried the built select.js and select.css from https://github.com/bmontgomery/ui-select/tree/master/dist with Bootstrap 4.1.1 and AngularJS 1.7.2, but the select widget is not working. If I add attribute theme="bootstrap4" on ui-select element, it is rendered like this If I add attribute theme="bootstrap" on ui-select element, it is rendered like this For both theme, when I click the input box , the choices are not displayed. If I change to use Bootstrap 3.3.7 with attribute theme="bootstrap" on ui-select element, the select widget is working as expected. Here is the code I use for testing ui-select-test.zip |
Upgrading Karma
Make Bootrap4-1 controls more accessible


Change ng-show="$select.open && $select.items.length > 0"
for this ng-class="{show : $select.open && $select.items.length > 0}"