Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Conversation

@orzilca
Copy link
Contributor

@orzilca orzilca commented Jun 27, 2015

Fixes various problems causing the editor not to show up or not to respond to ng-model change

Fixes various problems causing the editor not to show up or not to respond to ng-model change
@karthikbalu
Copy link

This is a very high priority fix and worked for me after hours of pain, can u please merge it ASAP pls
Thanks

@paivaric
Copy link

Please.. merge this... i need this too... tks!!!

@ryanberckmans
Copy link

This PR fixed my issue. I had ng-model="some.object.property"; model updates weren't calling ngModel.$render, so the editor wasn't synced with the model; I set priority: 999,; now it works.

@deeg deeg self-assigned this Oct 16, 2015
@deeg deeg added the bug label Oct 16, 2015
@deeg deeg added this to the 0.0.10 milestone Oct 16, 2015
@deeg
Copy link
Contributor

deeg commented Oct 17, 2015

I hate to set an arbitrary priority for no reason. So far I have not found any instances where a priority helped me.

Do you think you could post a Plunker or FIddle demonstrating the issue? If it is really fixing issues for many people I don't mind getting it into the next release, I just want to make sure we have some reason for it.

@deeg deeg modified the milestones: 0.0.11, 0.0.10 Oct 20, 2015
@deeg deeg added needs plunker and removed bug labels Oct 25, 2015
@AGiorgetti
Copy link

Looking at the Angular code I'm pretty sure the problem is in redefining 'ngModel.$render' and the order of execution of the directives.
Assuming you have no priority uiTinymce will run with the same priority as angular 'textarea' directive (which is defined by the 'inputDirective' variable, just look in the Angular code).
The linking function of this angular directive is redefining the ngModel.$render function too, and this can sometimes override uiTinymce $render function (no execution order guaranteed with directive of the same priority).
The code I'm talking about is at this link:
https://github.com/angular/angular.js/blob/40c974ab148cdbb80bd0f470f0ebf70f0fb228d4/src/ng/directive/input.js#L1171

@deeg deeg modified the milestones: 0.0.12, 0.0.13 Dec 28, 2015
@fabian
Copy link

fabian commented Feb 10, 2016

Here's a Plunker showing the issue: http://plnkr.co/edit/gxnnI1IuJv8aFjgPGPcs

@deeg deeg closed this in da64eb9 Feb 10, 2016
@deeg
Copy link
Contributor

deeg commented Feb 10, 2016

@fabian, thanks for posting the plunker.

I added priority with 999 for now, but I might change to a lower number if I hear it causes issues for people.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants