This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Fix for #264, using the tinymce init promise if available #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the tests pass again because the different tests don't dispose each other anymore (they did that by all using 'ui-tinymce-0' and removing the tinymce instance after each test, which led to interference with still running tests.
|
LGTM, can we merge this? |
|
Really need it... Still waiting... |
|
This one is good. Waiting for it too. |
|
also waiting |
|
Need this PR merged if possible! |
|
Waiting for this as well =) |
Contributor
|
Can you please squash this PR into one commit so I can get it merged in? |
| } | ||
| tinymce.init(options); | ||
| toggleDisable(scope.$eval(attrs.ngDisabled)); | ||
| var maybeInitPromise = tinymce.init(options); // newer versions of tinymce return a promise |
There was a problem hiding this comment.
tabs at the beginning here, messes up the indentation.
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a plnkr showing the issue:
http://plnkr.co/edit/R7oHmGcRkKz5ZZXSFo9h
And one showing it fixed:
http://plnkr.co/edit/F1QJlRPN8M04n3yNCgm5
The tests fail because of the line
beforeEach(module('ui.tinymce'));
which resets the variable generatedIds to zero before every test, resulting in duplicate ids in the test DOM. If it is replaced with something global, the tests pass. This should not happen in non-test use, I think. I just don't know how to tell jasmine to load the module only once.