Skip to content

fix(progress-spinner): not working with server-side rendering #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2017
Merged

fix(progress-spinner): not working with server-side rendering #4020

merged 1 commit into from
Apr 17, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 10, 2017 •
edited
Loading

  • Switches the progress spinner from using querySelector to ViewChild.
  • Moves all of the remaining DOM manipulation to the renderer.
  • Skips animations if requestAnimationFrame is not available.
  • Simplifies some overly-complex logic for adding/removing the theme class.

Fixes #3988.

@crisbeto
fix(progress-spinner): not working with server-side rendering
6339278 
* Switches the progress spinner from using `querySelector` to `ViewChild`.
* Moves all of the remaining DOM manipulation to the renderer.
* Skips animations if `requestAnimationFrame` is not available.
* Simplifies some unnecessarily complex logic for adding/removing the theme class.

Fixes angular#3988.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 10, 2017
jelbourn
jelbourn approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 13, 2017
@jelbourn jelbourn merged commit aebbd8a into angular:master Apr 17, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@angular/platform-server : this._elementRef.nativeElement.querySelector is not a function

3 participants

@crisbeto @jelbourn @googlebot