Skip to content

fix(cards): card title/subtitle support attribute selectors #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2017
Merged

fix(cards): card title/subtitle support attribute selectors #4122

merged 1 commit into from
Apr 21, 2017

Conversation

@willshowell
Copy link
Contributor

Fixes #3932.

Questions:

  • Should this attribute be limited to h1-h6 elements?
  • Should .mat-card-title and .mat-card-subtitle add margin-top: 0 to override the default margin applied to heading elements?

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 17, 2017
@jelbourn jelbourn requested a review from kara April 19, 2017 21:54
kara
kara approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 20, 2017
@kara kara removed their assignment Apr 20, 2017
@kara kara merged commit a200024 into angular:master Apr 21, 2017
@willshowell willshowell deleted the card-title-attribute branch May 24, 2017 15:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Card titles should support attribute selectors

3 participants

@willshowell @kara @googlebot