Skip to content

fix(datepicker): minValidator & maxValidation false errors #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2017
Merged

fix(datepicker): minValidator & maxValidation false errors #4649

merged 1 commit into from
May 26, 2017

Conversation

@BaimosTechnologies
Copy link

@BaimosTechnologies BaimosTechnologies commented May 18, 2017 •
edited by jelbourn
Loading

  • Min and max dates give false validation errors when selected date is one of the two
  • Include unit-tests to catch min/max validation errors

Fixes #4725

fix(datepicker): minValidator & maxValidation false errors
d3f4022 
* Min and max dates give false validation errors when selected date is one of the two
* Include unit-tests to catch min/max validation errors
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 18, 2017
@willshowell willshowell mentioned this pull request May 22, 2017
Closed
@jelbourn jelbourn requested a review from mmalerba May 23, 2017 00:53
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 23, 2017
@mmalerba
Copy link
Contributor

mmalerba commented May 23, 2017

LGTM, thanks for taking care of this

@tinayuangao tinayuangao merged commit b2c3ed0 into angular:master May 26, 2017
@ranouf ranouf mentioned this pull request May 29, 2017
Closed
@willshowell willshowell mentioned this pull request Jun 2, 2017
Closed
@BaimosTechnologies BaimosTechnologies deleted the fix-min-max-validation-branch branch June 2, 2017 14:22
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Datepicker minDate - error is raised when date is exactly min date

5 participants

@BaimosTechnologies @mmalerba @jelbourn @googlebot @tinayuangao