feat(tab-nav-bar): support disabling tab links #5257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for disabling tab links inside of the tab-nav-bar * No longer requires having an extra directive for the ripples of tab links (no exposion of attributes like `mdRippleColor` - which could be flexible but should not be public API here) Closes angular#5208
googlebot
added
the
cla: yes
jelbourn
reviewed
Jun 21, 2017
| inputs: ['disabled'], | ||
| host: { | ||
| 'class': 'mat-tab-link', | ||
| '[class.mat-tab-disabled]': 'disabled' |
Member
There was a problem hiding this comment.
Also needs aria-disabled and setting tabIndex to -1 (same as MdAnchor) with corresponding tests.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdRippleColor- which could be flexible but should not be public API here)Note:
I was not able to create a test that confirms that no ripples are showing up if tab links are disabled. This is because the ripples are disabled through the
pointer-eventsCSS property here.In theory it would be better to use
mdRippleDisabledhere but this would prevent us from using the disabled mixin and we would still need to use a separate class.cc. @jelbourn, @andrewseguin for thoughts.
Closes #5208