Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 4, 2017

Adds return types to the focus trap methods, allowing the consumer to react based on whether the focus trap managed to find a focusable element. This is useful for cases like the dialog where focus could be left behind if it is a purely text-based dialog.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 4, 2017
@crisbeto crisbeto force-pushed the focus-trap-result branch from db52793 to 98dcf7a Compare August 5, 2017 07:52
Adds return types to the focus trap methods, allowing the consumer to react based on whether the focus trap managed to find a focusable element. This is useful for cases like the dialog where focus could be left behind if it is a purely text-based dialog.
@crisbeto crisbeto force-pushed the focus-trap-result branch from 98dcf7a to 28e3530 Compare August 6, 2017 08:55
@crisbeto
Copy link
Member Author

crisbeto commented Aug 6, 2017

@jelbourn @mmalerba for the async methods, I ended up resolving with a boolean instead of resolving/rejecting. It seems like the async zone starts acting up if we have a rejected promise that isn't handled.

@mmalerba mmalerba merged commit 7626c51 into angular:master Aug 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants