Skip to content

fix(overlay): export OverlaySizeConfig #8932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2017
Merged

fix(overlay): export OverlaySizeConfig #8932

merged 1 commit into from
Dec 11, 2017

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Dec 11, 2017

Exporting OverlaySizeConfig as it is the type of the sizeConfig parameter for OverlayRef's updateSize method, but is not exported.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2017
@mmalerba mmalerba merged commit a626c8f into angular:master Dec 11, 2017
mmalerba pushed a commit that referenced this pull request Dec 11, 2017
@josephperrott @mmalerba
fix(overlay): export OverlaySizeConfig (#8932)
adfa31e
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
@josephperrott josephperrott deleted the overlay-export branch March 20, 2020 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

No one assigned

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josephperrott @googlebot @mmalerba