Skip to content

docs(changelog): fix wrong description #8945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2017
Merged

docs(changelog): fix wrong description #8945

merged 1 commit into from
Dec 14, 2017

Conversation

@rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Dec 12, 2017 •
edited
Loading

No description provided.

@rafaelss95 rafaelss95 requested a review from jelbourn as a code owner December 12, 2017 00:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 12, 2017
jelbourn
jelbourn approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 12, 2017
@rafaelss95
Copy link
Contributor Author

rafaelss95 commented Dec 12, 2017 •
edited
Loading

I think there are some problems with the changelog generation:

In addition to taking the initial title of PR instead of the latest, it's also appending any link from description to the title.

Does it worth to add a new issues to this? @jelbourn.

@andrewseguin andrewseguin merged commit 6794722 into angular:master Dec 14, 2017
@rafaelss95 rafaelss95 deleted the fix-changelog branch December 15, 2017 00:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rafaelss95 @jelbourn @googlebot @andrewseguin