💥Add CoefficientOfThermalExpansion units, change base unit #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartsPerMillionPerDegreesCelsius PartsPerMillionPerDegreesFahrenheit PartsPerMillionPerKelvin
tm-ren
changed the title
angularsen
changed the title
angularsen
requested changes
Jul 13, 2023
| ] | ||
| }, | ||
| { | ||
| "SingularName": "PartsPerMillionPerKelvin", |
Owner
There was a problem hiding this comment.
PartPer for singular. Other places too.
UnitsNet.Tests/CustomCode/CoefficientOfThermalExpansionTests.cs
Outdated
Show resolved
Hide resolved
Rename to PpmPer... Change base unit from InverseKelvin to PerKelvin. Remove abbreviations from InverseKelvin so that strings parse to the expected unit.
angularsen
requested changes
Jul 17, 2023
angularsen
changed the title
Owner
|
Thanks! Nuget should be out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1259
Add units
PerKelvin
PerDegreeCelsius
PerDegreeFahrenheit
PpmPerKelvin
PpmPerDegreeCelsius
PpmPerDegreeFahrenheit
💥Change base unit
From
InverseKelvintoPerKelvin.Obsolete units (renamed)
InverseKelvin
InverseDegreeCelsius
InverseDegreeFahrenheit