Add Tilt to Angle #918
Merged
Add Tilt to Angle #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
==========================================
- Coverage 82.70% 82.70% -0.01%
==========================================
Files 291 291
Lines 44040 44048 +8
==========================================
+ Hits 36423 36428 +5
- Misses 7617 7620 +3
Continue to review full report at Codecov.
|
angularsen
reviewed
Apr 9, 2021
|
Verifying the constant is trivial. In fact, had you not previously advised me against it, I wouldn’t have used a constant. I’d just have used:
protected override double TiltInOneDegree => Math.Sin(RadiansInOneDegree);
Hope that helps!
Brad.
From: Andreas Gullberg Larsen ***@***.***>
Sent: Thursday, April 8, 2021 11:36 PM
To: angularsen/UnitsNet ***@***.***>
Cc: Brad Plett ***@***.***>; Author ***@***.***>
Subject: Re: [angularsen/UnitsNet] Add Tilt to Angle (#918)
@angularsen commented on this pull request.
________________________________
In UnitsNet.Tests/CustomCode/AngleTests.cs<#918 (comment)>:
@@ -38,6 +38,8 @@ public class AngleTests : AngleTestsBase
protected override double RevolutionsInOneDegree => 2.777777777777777e-3;
+ protected override double TiltInOneDegree => 0.01745240643728351281941897851632;
Could you point me to a source reference where I can verify this, besides your calculation? I can't seem to find any.
I found these:
https://en.wikipedia.org/wiki/Inclinometer
https://en.wikipedia.org/wiki/Grade_(slope)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#918 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQORODUNLGBCF4AOI2R2WFLTH2N6TANCNFSM42UAD3LA>.
|
|
Ahh, sorry. I actually get lots of “hits”. Try this search: https://www.google.com/search?q=%2Btilt+meter+output+%2Bsine+angle
Using just the top three on the results I get:
From https://www.geosense.co.uk/media/BlockAttributeValueFile/152/file/2TiltMeterBeamApplicationGuideV1.0.pdf I get “The readings generated by Digital Tilt Sensors are in ‘Sine of the Angle’.”
From https://www.encardio.com/blog/tiltmeter-how-does-it-work-installation-how-to-read/ I get “The tilt sensor thus provides a bipolar DC voltage output proportional to the sine of tilt angle measured by the tiltmeter.”
From https://www.althensensors.com/landing-pages/tilt-angle-measurement/ I get “…provides an output signal of +/- 5 volts proportional to the sine wave”
I have nothing to do with any of those companies. 😊 Is that sufficient? Would you like more?
Thanks!
Brad.
From: Andreas Gullberg Larsen ***@***.***>
Sent: Friday, April 9, 2021 2:31 PM
To: angularsen/UnitsNet ***@***.***>
Cc: Brad Plett ***@***.***>; Mention ***@***.***>
Subject: Re: [angularsen/UnitsNet] Add Tilt to Angle (#918)
@angularsen commented on this pull request.
________________________________
In UnitsNet.Tests/CustomCode/AngleTests.cs<#918 (comment)>:
@@ -38,6 +38,8 @@ public class AngleTests : AngleTestsBase
protected override double RevolutionsInOneDegree => 2.777777777777777e-3;
+ protected override double TiltInOneDegree => 0.01745240643728351281941897851632;
@bplett-wgtcorp<https://github.com/bplett-wgtcorp> Right, but what I meant is that I can't find any source of reference that says the measurement "tilt" equals Sin(radians) of an angle. A wiki or unit converter or any kind of digital source would be helpful to verify this unit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#918 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQORODSDKAGI7X5IAIWTQ5DTH5W2ZANCNFSM42UAD3LA>.
|
|
Fantastic! Thanks a lot!
Brad.
From: Andreas Gullberg Larsen ***@***.***>
Sent: Friday, April 9, 2021 3:31 PM
To: angularsen/UnitsNet ***@***.***>
Cc: Brad Plett ***@***.***>; Mention ***@***.***>
Subject: Re: [angularsen/UnitsNet] Add Tilt to Angle (#918)
@angularsen commented on this pull request.
________________________________
In UnitsNet.Tests/CustomCode/AngleTests.cs<#918 (comment)>:
@@ -38,6 +38,8 @@ public class AngleTests : AngleTestsBase
protected override double RevolutionsInOneDegree => 2.777777777777777e-3;
+ protected override double TiltInOneDegree => 0.01745240643728351281941897851632;
@bplett-wgtcorp<https://github.com/bplett-wgtcorp> Thanks, no those are plenty!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#918 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQORODVUD4FHXLP3XHEXJMDTH553PANCNFSM42UAD3LA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Tilt" is commonly used in Tilt Meters, and it is simply the Sin of the angle.