Skip to content

Conversation

@Andersson007
Copy link
Collaborator

SUMMARY

Stop testing against Ansible 2.9 and ansible-base 2.10 as they'll get EOL in May 2022

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #343 (9610716) into main (ba4fea6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files          27       27           
  Lines        2267     2267           
  Branches      550      550           
=======================================
  Hits         1773     1773           
  Misses        335      335           
  Partials      159      159           
Impacted Files Coverage Δ
plugins/module_utils/version.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4fea6...9610716. Read the comment docs.

@Andersson007 Andersson007 merged commit eff87f9 into ansible-collections:main May 12, 2022
@patchback
Copy link

patchback bot commented May 12, 2022

Backport to stable-2: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply eff87f9 on top of patchback/backports/stable-2/eff87f952bf8adb543bd77eedf7ecd518054f2ca/pr-343

Backporting merged PR #343 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.mysql.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-2/eff87f952bf8adb543bd77eedf7ecd518054f2ca/pr-343 upstream/stable-2
  4. Now, cherry-pick PR Drop support for Ansible 2.9 and ansible-base 2.10 #343 contents into that branch:
    $ git cherry-pick -x eff87f952bf8adb543bd77eedf7ecd518054f2ca
    If it'll yell at you with something like fatal: Commit eff87f952bf8adb543bd77eedf7ecd518054f2ca is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x eff87f952bf8adb543bd77eedf7ecd518054f2ca
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Drop support for Ansible 2.9 and ansible-base 2.10 #343 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-2/eff87f952bf8adb543bd77eedf7ecd518054f2ca/pr-343
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented May 12, 2022

Backport to stable-1: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply eff87f9 on top of patchback/backports/stable-1/eff87f952bf8adb543bd77eedf7ecd518054f2ca/pr-343

Backporting merged PR #343 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.mysql.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-1/eff87f952bf8adb543bd77eedf7ecd518054f2ca/pr-343 upstream/stable-1
  4. Now, cherry-pick PR Drop support for Ansible 2.9 and ansible-base 2.10 #343 contents into that branch:
    $ git cherry-pick -x eff87f952bf8adb543bd77eedf7ecd518054f2ca
    If it'll yell at you with something like fatal: Commit eff87f952bf8adb543bd77eedf7ecd518054f2ca is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x eff87f952bf8adb543bd77eedf7ecd518054f2ca
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Drop support for Ansible 2.9 and ansible-base 2.10 #343 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-1/eff87f952bf8adb543bd77eedf7ecd518054f2ca/pr-343
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request May 12, 2022
…ns#343)

* Drop support for Ansible 2.9 and ansible-base 2.10

* Improve README

(cherry picked from commit eff87f9)
Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request May 12, 2022
…ns#343)

* Drop support for Ansible 2.9 and ansible-base 2.10

* Improve README

(cherry picked from commit eff87f9)
Andersson007 added a commit that referenced this pull request May 12, 2022
* Drop support for Ansible 2.9 and ansible-base 2.10

* Improve README

(cherry picked from commit eff87f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant