feat: enable matplotlib and plotly in examples #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
jorgepiloto
changed the title
jorgepiloto
commented
Oct 25, 2024
Member
Author
|
Plotly and matplotlib are supported. Main issue here is that the different extensions are getting in conflict because "sphinx-gallery" generates a bunch of files. Still working on it. |
Revathyvenugopal162
approved these changes
Oct 28, 2024
MaxJPRey
reviewed
Oct 28, 2024
MaxJPRey
reviewed
Oct 28, 2024
MaxJPRey
reviewed
Oct 28, 2024
Member
|
What's the status with this PR? It's been going on since Oct 2024 |
Contributor
We are working on this and trying to get this with theme v1.4 |
MaxJPRey
approved these changes
Mar 14, 2025
Contributor
|
tested with ansys/pymapdl#2346 |
jorgepiloto
commented
Mar 19, 2025
jorgepiloto
commented
Mar 19, 2025
jorgepiloto
commented
Mar 19, 2025
Member
Author
jorgepiloto
left a comment
jorgepiloto
left a comment
There was a problem hiding this comment.
Almost there, just left some comments.
Co-authored-by: Jorge Martínez <[email protected]>
Contributor
Incorporated all the comments, Thanks @jorgepiloto |
Member
Author
|
Thanks for taking the lead here, @Revathyvenugopal162. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes #301 by ensuring plotly is supported in our theme. Matplotlib support is explored too.
summary
We had to add our own hook because we support both
nbsphinxandsphinx-gallerysimultaneously. This was causing nbsphinx to execute notebooks generated by sphinx-gallery again, leading to errors.But this is specifically for ansys-sphinx-theme
Additionally, regarding Plotly (which was the original focus of this PR), insights are:
Images
Sphinx gallery
nbsphinx
