Skip to content

Conversation

@germa89
Copy link
Contributor

@germa89 germa89 commented May 13, 2025

As the title. For better developer experience.

I am running on macOS, so I couldnt check the bat file. The Makefile does work though!

@germa89 germa89 requested a review from a team as a code owner May 13, 2025 15:00
@germa89 germa89 self-assigned this May 13, 2025
@github-actions github-actions bot added enhancement General improvements to existing features docs Issues related to documentation labels May 13, 2025
@germa89
Copy link
Contributor Author

germa89 commented May 14, 2025

@Revathyvenugopal162 CI jobs CI/Vale seems redundant with Doc style...

@jorgepiloto
Copy link
Member

We are moving from these files to tox. In fact, there is the tox -e doc-serve command, which serves the documentation right now.

@germa89
Copy link
Contributor Author

germa89 commented May 14, 2025

I dont mind tox or make file. But I think we should use one of those, since the purpose of them is to unify the repository commands.

Copy link
Contributor Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments. But it looks good to me.

@germa89
Copy link
Contributor Author

germa89 commented May 27, 2025

Are we ready to merge this?

@germa89 germa89 enabled auto-merge (squash) May 27, 2025 09:29
@germa89 germa89 merged commit 3ca5479 into main May 27, 2025
19 checks passed
@germa89 germa89 deleted the feat/adding-serve-to-makefile branch May 27, 2025 09:36
@germa89
Copy link
Contributor Author

germa89 commented May 27, 2025

Upsss.... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues related to documentation enhancement General improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants