Skip to content

Conversation

@RobPasMue
Copy link
Member

Controlling usage of subprocess (only for Windows OS) and avoid using shell=True.

@RobPasMue RobPasMue self-assigned this Mar 21, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner March 21, 2024 16:21
@github-actions github-actions bot added the bug Something isn't working label Mar 21, 2024
@RobPasMue RobPasMue requested a review from PipKat as a code owner March 21, 2024 16:22
@RobPasMue RobPasMue changed the title maint: prepare_and_start_backend is only available on Windows fix: prepare_and_start_backend is only available on Windows Mar 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (138ae18) to head (5de3d35).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files          93       93           
  Lines        6835     6835           
=======================================
  Hits         6167     6167           
  Misses        668      668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit f82346b into main Mar 21, 2024
@RobPasMue RobPasMue deleted the fix/shell-subprocess branch March 21, 2024 16:45
RobPasMue added a commit that referenced this pull request Mar 22, 2024
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
RobPasMue added a commit that referenced this pull request Mar 22, 2024
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants