Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

Following investigations from #1748 - the helper script available for building the Geometry Service Docker container was broken. Special thanks to @som1197 for raising the issue!!

Issue linked

Closes #1748

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Feb 27, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner February 27, 2025 08:44
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 27, 2025
@RobPasMue RobPasMue merged commit cdd6dc4 into main Feb 27, 2025
43 checks passed
@RobPasMue RobPasMue deleted the feat/fix-docker-build branch February 27, 2025 09:05
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (8ae7558) to head (99f2adf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1785   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          92       92           
  Lines        8357     8357           
=======================================
  Hits         7595     7595           
  Misses        762      762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants