Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

Added the ExtrudeType parameter for revolve_faces and revolve_faces_by_helix
Default value is ExtrudeType.ADD

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

RobPasMue and others added 5 commits February 6, 2025 16:15
…o feat/revolve_faces_and_helix_options

# Conflicts:
#	src/ansys/geometry/core/designer/body.py
#	src/ansys/geometry/core/designer/geometry_commands.py
#	tests/integration/test_geometry_commands.py
@jacobrkerstetter jacobrkerstetter added the enhancement New features or code improvements label Mar 17, 2025
@jacobrkerstetter jacobrkerstetter self-assigned this Mar 17, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner March 17, 2025 15:03
@RobPasMue
Copy link
Member

It seems like a server branch needs to get in before we can merge this

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (3835d66) to head (c9528c0).
Report is 1 commits behind head on blitz.

Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1842      +/-   ##
==========================================
+ Coverage   90.17%   90.18%   +0.01%     
==========================================
  Files          92       92              
  Lines        8801     8801              
==========================================
+ Hits         7936     7937       +1     
+ Misses        865      864       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit d3fcc9d into blitz Mar 19, 2025
24 of 25 checks passed
@RobPasMue RobPasMue deleted the feat/revolve_faces_and_helix_options branch March 19, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants