-
Notifications
You must be signed in to change notification settings - Fork 22
feat: revolve faces and revolve faces by helix options #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tests for both methods
…o feat/revolve_faces_and_helix_options # Conflicts: # src/ansys/geometry/core/designer/body.py # src/ansys/geometry/core/designer/geometry_commands.py # tests/integration/test_geometry_commands.py
RobPasMue
approved these changes
Mar 18, 2025
Member
|
It seems like a server branch needs to get in before we can merge this |
….com/ansys/pyansys-geometry into feat/revolve_faces_and_helix_options
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## blitz #1842 +/- ##
==========================================
+ Coverage 90.17% 90.18% +0.01%
==========================================
Files 92 92
Lines 8801 8801
==========================================
+ Hits 7936 7937 +1
+ Misses 865 864 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ExtrudeType parameter for revolve_faces and revolve_faces_by_helix
Default value is ExtrudeType.ADD
Issue linked
Checklist
feat: extrude circle to cylinder)