Skip to content

Conversation

@RobPasMue
Copy link
Member

Coming from conda-forge/ansys-geometry-core-feedstock#26

We should avoid having it "completely necessary" for conda purposes... Although it can be a pip dependency, let's avoid it in conda

@RobPasMue RobPasMue self-assigned this Apr 9, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner April 9, 2025 15:20
@RobPasMue RobPasMue changed the title fix: geomdl dependency fix: geomdl dependency in conda-forge Apr 9, 2025
@github-actions github-actions bot added the bug Something isn't working label Apr 9, 2025
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (32df1cd) to head (47ff5e1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.02%     
==========================================
  Files         105      108       +3     
  Lines        9330     9385      +55     
==========================================
+ Hits         8433     8481      +48     
- Misses        897      904       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 7c0ab70 into main Apr 9, 2025
35 checks passed
@RobPasMue RobPasMue deleted the fix/geomdl-dependency branch April 9, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants