Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

  • refactor components code to handle gRPC calls from versioned architecture
  • fixed descriptive beams method to handle gRPC objects in central gRPC location

Issue linked

#1817

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Sep 26, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner September 26, 2025 11:52
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 26, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 92.24138% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.53%. Comparing base (86bbb5c) to head (5dffcd3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...sys/geometry/core/_grpc/_services/v1/components.py 68.96% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
- Coverage   94.58%   94.53%   -0.05%     
==========================================
  Files         160      163       +3     
  Lines       10919    11006      +87     
==========================================
+ Hits        10328    10405      +77     
- Misses        591      601      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RobPasMue
RobPasMue previously approved these changes Sep 26, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) September 26, 2025 15:01
@RobPasMue RobPasMue merged commit afb33f7 into main Sep 26, 2025
79 of 82 checks passed
@RobPasMue RobPasMue deleted the feat/components_stub_refactoring branch September 26, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants