Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Sep 30, 2025

Description

  • NURBS surface conversion to communicate with gRPC
  • tested creating NURBS surface body after trimming

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Sep 30, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner September 30, 2025 14:03
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 30, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Sep 30, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.52%. Comparing base (6546de8) to head (8803f36).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/component.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2273   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         169      169           
  Lines       11008    11034   +26     
=======================================
+ Hits        10405    10430   +25     
- Misses        603      604    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Oct 1, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes! =)

RobPasMue
RobPasMue previously approved these changes Oct 1, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 suggestions - once merged, good to go!

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging!

@RobPasMue RobPasMue enabled auto-merge (squash) October 1, 2025 13:25
@RobPasMue RobPasMue merged commit cd1197f into main Oct 1, 2025
126 of 129 checks passed
@RobPasMue RobPasMue deleted the feat/nurbs_surface_body_creation branch October 1, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants