-
Notifications
You must be signed in to change notification settings - Fork 22
feat: NURBS surface body creation #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… feat/nurbs_surface_body_creation
…/ansys/pyansys-geometry into feat/nurbs_surface_body_creation
…/ansys/pyansys-geometry into feat/nurbs_surface_body_creation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 169 169
Lines 11008 11034 +26
=======================================
+ Hits 10405 10430 +25
- Misses 603 604 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/ansys/pyansys-geometry into feat/nurbs_surface_body_creation
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few changes! =)
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 suggestions - once merged, good to go!
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging!
Description
Issue linked
Checklist
feat: extrude circle to cylinder)