Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

Preventing the usage of invalid kwargs in the launcher methods

Issue linked

Closes #2287

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 8, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner October 8, 2025 07:27
@github-actions github-actions bot added the testing Anything related to tests label Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (58cb516) to head (8c45a74).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
+ Coverage   94.44%   94.48%   +0.04%     
==========================================
  Files         169      169              
  Lines       11164    11175      +11     
==========================================
+ Hits        10544    10559      +15     
+ Misses        620      616       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue added the enhancement New features or code improvements label Oct 8, 2025
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@jacobrkerstetter jacobrkerstetter merged commit 4b76c44 into main Oct 8, 2025
55 checks passed
@jacobrkerstetter jacobrkerstetter deleted the test/kwargs-past-not-accepted branch October 8, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoiding the usage of invalid arguments in specific launch methods

4 participants