Skip to content

Conversation

@b-matteo
Copy link
Contributor

@b-matteo b-matteo commented Oct 14, 2025

Re enable logs testing

Description

Unskip test as the issue has been fixed in the backend.

Issue linked

#2310

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Unskip test as the issue has been fixed in the backend.
@b-matteo b-matteo requested a review from RobPasMue October 14, 2025 15:37
@b-matteo b-matteo self-assigned this Oct 14, 2025
@b-matteo b-matteo requested a review from a team as a code owner October 14, 2025 15:37
@b-matteo b-matteo added the bug Something isn't working label Oct 14, 2025
@RobPasMue RobPasMue linked an issue Oct 14, 2025 that may be closed by this pull request
RobPasMue
RobPasMue previously approved these changes Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.23%. Comparing base (dd1efda) to head (2b5df0c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
+ Coverage   95.03%   95.23%   +0.19%     
==========================================
  Files         169      169              
  Lines       11180    11180              
==========================================
+ Hits        10625    10647      +22     
+ Misses        555      533      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue changed the title Fix: re enable logs testing fix: re enable logs testing Oct 15, 2025
@RobPasMue RobPasMue enabled auto-merge (squash) October 16, 2025 05:54
@RobPasMue RobPasMue merged commit 8b3f393 into main Oct 16, 2025
149 of 159 checks passed
@RobPasMue RobPasMue deleted the fix/service_log_retrievals branch October 16, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issues with service log retrievals

4 participants