Skip to content

Conversation

@smereu
Copy link
Contributor

@smereu smereu commented Oct 15, 2025

Description

This PR finalizes the migration of the design class to use mediator service for version handling

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

pyansys-ci-bot and others added 20 commits February 17, 2025 14:31
@smereu smereu requested a review from a team as a code owner October 15, 2025 03:49
@smereu smereu self-assigned this Oct 15, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.15%. Comparing base (f58972a) to head (550a901).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/ansys/geometry/core/_grpc/_services/v1/beams.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2323      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.02%     
==========================================
  Files         169      169              
  Lines       11180    11194      +14     
==========================================
+ Hits        10640    10652      +12     
- Misses        540      542       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes - thanks for taking the time @smereu !!

@smereu
Copy link
Contributor Author

smereu commented Oct 15, 2025

@RobPasMue I should marked this as draft last night but I am glad you reviewed it. I will make the changes today!

@RobPasMue
Copy link
Member

@RobPasMue I should marked this as draft last night but I am glad you reviewed it. I will make the changes today!

No problem =) thanks @smereu !!

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) October 17, 2025 13:57
@RobPasMue RobPasMue merged commit 711ab4a into main Oct 17, 2025
50 checks passed
@RobPasMue RobPasMue deleted the feat/finalize-version-for-design-class branch October 17, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants