-
Notifications
You must be signed in to change notification settings - Fork 22
feat: finalize version handling for design class #2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
- Coverage 95.16% 95.15% -0.02%
==========================================
Files 169 169
Lines 11180 11194 +14
==========================================
+ Hits 10640 10652 +12
- Misses 540 542 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few changes - thanks for taking the time @smereu !!
…ub.com/ansys/pyansys-geometry into feat/finalize-version-for-design-class
|
@RobPasMue I should marked this as draft last night but I am glad you reviewed it. I will make the changes today! |
No problem =) thanks @smereu !! |
…ub.com/ansys/pyansys-geometry into feat/finalize-version-for-design-class
…ub.com/ansys/pyansys-geometry into feat/finalize-version-for-design-class
…ub.com/ansys/pyansys-geometry into feat/finalize-version-for-design-class
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR finalizes the migration of the design class to use mediator service for version handling
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)