Skip to content

Conversation

@jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Apr 5, 2023

If #473 get merged first, we need to reset tessellation cache on (both bodies?) in these methods, since they directly modify the body.

@jonahrb jonahrb requested a review from RobPasMue as a code owner April 5, 2023 16:26
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 5, 2023
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we might want to merge in first #473 and then implement it here. Some intersting assumptions in this PR. Let's talk when you have the chance before approving.

RobPasMue
RobPasMue previously approved these changes Apr 17, 2023
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just adding the reset tessellation decorators

@RobPasMue RobPasMue enabled auto-merge (squash) April 17, 2023 15:09
@RobPasMue RobPasMue merged commit d27b1d9 into main Apr 17, 2023
@RobPasMue RobPasMue deleted the feat/boolean-methods branch April 17, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants