feat: import surface body properly when reading design + boolean ops with multiple bodies #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
jonahrb
previously approved these changes
Nov 10, 2023
Member
Author
|
Requires some extra changes for boolean operations. Working on them now. And adding some tests for that |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
- Coverage 92.12% 92.11% -0.02%
==========================================
Files 83 83
Lines 5890 5895 +5
==========================================
+ Hits 5426 5430 +4
- Misses 464 465 +1 ☔ View full report in Codecov by Sentry. |
jonahrb
previously approved these changes
Nov 13, 2023
Contributor
|
@RobPasMue Maybe rename PR to reflect boolean changes? |
for more information, see https://pre-commit.ci
…yansys-geometry into feat/import_surface_body
…yansys-geometry into feat/import_surface_body
RobPasMue
changed the title
Member
Author
|
@jonahrb - can I get an approval here? |
RobPasMue
added a commit
that referenced
this pull request
Nov 29, 2023
…with multiple bodies (#846) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #834