Skip to content

Conversation

@hui-zhou-a
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the grpc-transition Changes that need to be included in gRPC transition label Jan 29, 2025
@hui-zhou-a hui-zhou-a changed the title Refatcor edb cfg equipotential region REFACTOR: edb cfg equipotential region Jan 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 28 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (ec2b640) to head (4ca783a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
- Coverage   82.67%   82.56%   -0.11%     
==========================================
  Files         160      160              
  Lines       21213    21248      +35     
==========================================
+ Hits        17537    17544       +7     
- Misses       3676     3704      +28     

svandenb-dev
svandenb-dev previously approved these changes Jan 29, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added documentation Improvements or additions to documentation testing Anything related to testing labels Jan 30, 2025
@hui-zhou-a hui-zhou-a marked this pull request as draft January 30, 2025 12:42
@hui-zhou-a
Copy link
Collaborator Author

hui-zhou-a commented Jan 30, 2025

@svandenb-dev the customer is testing this new feature, and I am getting new requests. I set this pr to draft for now

@hui-zhou-a hui-zhou-a self-assigned this Jan 31, 2025
@hui-zhou-a hui-zhou-a marked this pull request as ready for review January 31, 2025 09:12
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev enabled auto-merge (squash) January 31, 2025 09:15
@svandenb-dev svandenb-dev merged commit e0cabf0 into main Jan 31, 2025
24 checks passed
@svandenb-dev svandenb-dev deleted the refatcor-edb-cfg-equipotential-region branch January 31, 2025 10:01
@svandenb-dev svandenb-dev mentioned this pull request Mar 17, 2025
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants