Skip to content

Conversation

@hui-zhou-a
Copy link
Collaborator

Add material thermal modifier support

@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels May 14, 2025
@hui-zhou-a hui-zhou-a linked an issue May 14, 2025 that may be closed by this pull request
ring630 and others added 3 commits May 14, 2025 21:26
…modifier2

# Conflicts:
#	tests/legacy/system/test_edb_configuration_2p0.py
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (e0db428) to head (7769748).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
+ Coverage   81.09%   81.17%   +0.08%     
==========================================
  Files         161      161              
  Lines       23255    23292      +37     
==========================================
+ Hits        18858    18907      +49     
+ Misses       4397     4385      -12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ring630 added 10 commits May 15, 2025 09:09
@hui-zhou-a hui-zhou-a requested a review from svandenb-dev May 15, 2025 15:14
@hui-zhou-a hui-zhou-a removed the testing Anything related to testing label May 16, 2025
@github-actions github-actions bot added the testing Anything related to testing label May 16, 2025
@svandenb-dev svandenb-dev mentioned this pull request May 19, 2025
60 tasks
Copy link
Collaborator Author

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

svandenb-dev
svandenb-dev previously approved these changes May 19, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit bb62697 into main May 19, 2025
26 checks passed
@svandenb-dev svandenb-dev deleted the thermal_modifier2 branch May 19, 2025 11:31
@hui-zhou-a hui-zhou-a linked an issue May 22, 2025 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in Edb.close()

4 participants