Skip to content

Conversation

@SMoraisAnsys
Copy link
Collaborator

Ensure that users creating material through pyedb end up with a material with a permeability equal to 1 instead of 0 (default value retrieved through EDB API).

Closes #827

@github-actions github-actions bot added the grpc-transition Changes that need to be included in gRPC transition label Oct 21, 2024
@github-actions github-actions bot added the testing Anything related to testing label Oct 21, 2024
@SMoraisAnsys SMoraisAnsys self-assigned this Oct 21, 2024
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review October 21, 2024 13:40
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 8720d6c into main Oct 21, 2024
29 checks passed
@svandenb-dev svandenb-dev deleted the feat/add-material-default-permeability branch October 21, 2024 15:54
@svandenb-dev svandenb-dev mentioned this pull request Mar 17, 2025
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default permeability value of new material cannot be 0

4 participants