FEAT: Via clustering based on polygon #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pyedb/dotnet/edb_core/edb_data/hfss_pi_simulation_setup_data.py # src/pyedb/dotnet/edb_core/utilities/simulation_setup.py
# Conflicts: # src/pyedb/dotnet/edb_core/components.py
github-actions
bot
added
testing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 82.68% 82.67% -0.02%
==========================================
Files 160 160
Lines 21052 21098 +46
==========================================
+ Hits 17407 17442 +35
- Misses 3645 3656 +11 |
boyang2022
reviewed
Dec 13, 2024
boyang2022
approved these changes
Dec 13, 2024
boyang2022
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new feature with evaluating padstack instances included on points list and replace them by single instance.
By doing this we are simplifying meshing effort.
closing #943