fix: Nightly dev test due to updates in 'wait_for_process_finished'. #4575
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
hpohekar,
mayankansys and
seanpearsonuk
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a nightly development test failure caused by duplicate calls to exit the solver session. The wait_for_process_finished method was updated to handle process cleanup, making the explicit exit call in the test redundant and problematic.
Key changes:
- Removed redundant
solver_session.exit()call from thetest_simple_solvetest function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hpohekar
approved these changes
Oct 31, 2025
mkundu1
approved these changes
Oct 31, 2025
mkundu1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The test fixture was already exiting the solver session, thus exit was called twice.
Change Summary
Removed exit call from the test.
Rationale
As the exit was already called in the fixture.
This updated behavior is correct as redundant call to exit will be caught now.