fix: example deprecation warnings and improvements #4579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Gobot1234
requested review from
hpohekar,
mayankansys,
mkundu1,
prmukherj and
seanpearsonuk
as code owners
github-actions
bot
added
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes deprecation warnings by updating all references from direct solver session settings access (solver.setup.models) to the correct settings-based access pattern (solver.settings.setup.models). Additionally, it adds PEP 723 style dependencies to example scripts and includes minor improvements throughout.
- Updates deprecated direct access patterns to settings-based access across all test files and examples
- Adds PEP 723 dependency declarations to example scripts for standalone execution
- Includes miscellaneous code improvements and cleanups
Reviewed Changes
Copilot reviewed 67 out of 68 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/ | Updates test files to use solver.settings instead of direct access patterns |
| examples/ | Adds PEP 723 dependency headers and updates deprecated settings access |
| src/ | Updates core library files to use settings-based access pattern |
| doc/ | Updates documentation examples to reflect new access patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkundu1
approved these changes
Nov 3, 2025
hpohekar
approved these changes
Nov 4, 2025
|
Anyone have any opinions on #4512 (review)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When solver session settings access was deprecated directly on solver the code wasn't updated I've also sprinkled in a couple of small improvements to the examples
Change Summary
Updated all references direct access patterns (
solver.setup.models) to the correct settings-based access pattern (solver.settings.setup.models) along with adding PEP 723 styles dependencies to the examples to make them easier to run as standalone scripts.Rationale
Fixes all the deprecation warnings
Impact
Changes basically everywhere