Skip to content

Conversation

@wang1212
Copy link
Member

@wang1212 wang1212 commented Sep 8, 2025

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2001

💡 Background and solution

Problem Description:

In the current implementation, it is necessary to traverse the list of elements in the scene graph multiple times, which has an impact on performance, and the superposition effect of different events exacerbates the performance problem.

This pattern of traversing elements and triggering events is a bit like the early web standard MutationEvent, which has been deprecated and replaced by MutationObserve. It can be seen that this is an anti-pattern.

see https://developer.chrome.com/blog/mutation-events-deprecation

In addition, the performance problem of this implementation is obvious, so G uses the reuse mechanism of event objects to improve performance, but this approach has been proven to be insignificant. At the same time, we also conducted a simple test:

image

see facebook/react#18216

Solution:

The processing of internal element events is changed to batch triggering.

  • Create a list of elements only once
  • Events are only triggered on canvas instance (root element) only once
  • Event objects are no longer shared

Impact:

  • ElementEvent.BOUNDS_CHANGED (internal)

📝 Changelog

Language Changelog
🇺🇸 English perf: element event batch triggering
🇨🇳 Chinese perf: 批处理元素事件

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2025

🦋 Changeset detected

Latest commit: bb9d351

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 47 packages
Name Type
@antv/g-plugin-canvaskit-renderer Minor
@antv/g-plugin-canvas-renderer Minor
@antv/g-plugin-device-renderer Minor
@antv/g-plugin-html-renderer Minor
@antv/g-plugin-image-loader Minor
@antv/g-plugin-svg-renderer Minor
@antv/g-plugin-a11y Minor
@antv/g-plugin-yoga Minor
@antv/g-lite Minor
@antv/g-canvaskit Patch
@antv/g-canvas Patch
@antv/g-mobile-canvas Patch
@antv/g-plugin-canvas-picker Patch
@antv/g-mobile-webgl Patch
@antv/g-plugin-3d Patch
@antv/g-webgl Patch
@antv/g-webgpu Patch
@antv/g-mobile-svg Patch
@antv/g-plugin-svg-picker Patch
@antv/g-plugin-zdog-svg-renderer Patch
@antv/g-svg Patch
@antv/g-camera-api Patch
@antv/g-components Patch
@antv/g-dom-mutation-observer-api Patch
@antv/g-gesture Patch
@antv/g-image-exporter Patch
@antv/g-lottie-player Patch
@antv/g-mobile-canvas-element Patch
@antv/g-pattern Patch
@antv/g-plugin-annotation Patch
@antv/g-plugin-box2d Patch
@antv/g-plugin-canvas-path-generator Patch
@antv/g-plugin-control Patch
@antv/g-plugin-css-select Patch
@antv/g-plugin-dom-interaction Patch
@antv/g-plugin-dragndrop Patch
@antv/g-plugin-gesture Patch
@antv/g-plugin-matterjs Patch
@antv/g-plugin-mobile-interaction Patch
@antv/g-plugin-physx Patch
@antv/g-plugin-rough-canvas-renderer Patch
@antv/g-plugin-rough-svg-renderer Patch
@antv/g-plugin-zdog-canvas-renderer Patch
@antv/g-web-animations-api Patch
@antv/g-web-components Patch
@antv/g Patch
@antv/react-g Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wang1212 wang1212 marked this pull request as ready for review October 9, 2025 06:14
@wang1212
Copy link
Member Author

wang1212 commented Oct 9, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant performance improvement by refactoring the element event triggering mechanism to a batched approach, similar to MutationObserver. The changes are well-implemented across the core services and plugins. The addition of new benchmarks is also a great way to validate the performance gains. I've found a few minor issues in the new test files that could be addressed to improve code quality.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@wang1212 wang1212 merged commit 6a7c5bc into release Oct 9, 2025
2 checks passed
@wang1212 wang1212 deleted the perf/attr-update branch October 9, 2025 08:24
wang1212 added a commit that referenced this pull request Oct 13, 2025
* feat(benchmark): Add performance test suite and analysis panel (#1987)

* fix: docs dead links (#1984)

* fix: docs dead links

* fix: add /en prefix to english docs

* feat: upgrade chrome extension to manifest v3 and react to v18

- Upgrade manifest version from v2 to v3 with updated permissions format
- Migrate background scripts to service worker
- Update content_security_policy and web_accessible_resources format
- Replace browser_action with action
- Upgrade react and react-dom from v16 to v18 in g-devtool
- Update devtool UI to support React 18 createRoot API
- Maintain backward compatibility with legacy versions
- Update minimum chrome version requirement to 88

* feat: add GitHub workflow for bug report reproduction check

- Add new GitHub Actions workflow 'bug-report-reproduction-check'
- Automatically analyze new bug reports for reproduction steps
- Use Mistral AI to check for complete reproduction information
- Add friendly comment when reproduction details are missing
- Only trigger for issues labeled as 'bug'
- Add necessary permissions for issues and models access

* feat: add benchmark suite for rendering performance comparison

- Add benchmark infrastructure with TestCase and TestRunner base classes
- Implement test cases for basic shapes (circle, rect, path, etc.) across multiple renderers
- Support g-canvas, g-canvas-v4 and zrender rendering engines
- Add UI components for test execution and result visualization
- Include i18n support with Chinese and English translations
- Set up build configuration with Vite and TypeScript

* feat(benchmark): add collapsible insight panel in PerformanceChart

- Add state to track insight panel expansion
- Implement collapsible UI with smooth animations
- Improve styling and layout of insight panel
- Add expand/collapse toggle functionality
- Enhance user experience with better visual feedback

* chore(benchmark): add performance test results for basic shapes

Add benchmark results for basic shapes rendering comparison between different engines including g-canvas and zrender. The results include execution duration and memory usage metrics.

* feat(benchmark): enhance i18n support for failure rate display

- Add new translation key 'highestFailureRate' for displaying failure rate in both English and Chinese
- Refactor failure rate display to use i18n template
- Improve code formatting in PerformanceChart component
- Fix whitespace and indentation issues in TestRunner

* chore: remove other file

* feat: Add native pan and zoom demo (#1994)

* feat: add native pan and zoom demo

Adds a new demo under `__tests__/demos/camera/` that showcases how to implement panning and zooming on the canvas using native DOM events.

This is in response to the user request to add such a demo.

An issue in the execution environment prevented the test suite from being run. A `commitlint` hook blocked all commands, including `pnpm test`. The changes are submitted without test verification due to this environmental constraint.

* fix: use getContextService for container access in nativePanZoom demo

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: wang1212 <[email protected]>

* feat: add script to fetch and display npm download stats for monorepo packages

* chore: update test config and TypeScript settings

- Add JSDoc link to jest.unit.config.js
- Fix module name mapper path in jest.unit.config.js
- Expand coverage collection to more packages
- Update coverage reporters
- Move isolatedModules to tsconfig.json

* fix: fix loop index in tapable (#2003)

* fix: fix loop index in SyncWaterfallHook and AsyncSeriesWaterfallHook

- Fix loop index in SyncWaterfallHook to start from 1 instead of 0 since the first callback is already called
- Apply the same fix to AsyncSeriesWaterfallHook for consistency
- Add comprehensive unit tests for all tapable hook types

* chore: fix code style

* chore: fix code lint issue

* chore: add changeset

* Add basic shape benchmark cases for g-canvas-local engine (#2030)

* test: Add basic shape benchmark cases for g-canvas-local engine

* test: Add basic shape benchmark cases for g-canvas-local engine

* Update benchmark/src/benchmarks/g-canvas-local/engine.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* feat(text): add text-decoration support for text elements (#2035)

* feat(text): add text-decoration support for text elements

* docs: update text decoration info

* docs: fix typos

* perf: element event batch triggering (#2005)

* perf: element event batch triggering

* chore: update test snapshot

* chore: use Array.from to convert iterator for compatibility

* chore: add changeset

* Update __tests__/demos/perf/custom-event.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* perf: remove rBush logic from element picking mechanism (#2031)

* perf: remove rBush logic from element picking mechanism

* chore: fix lint error

* chore: add changeset

* chore: update test case

* fix: the element picking range includes the element border

* chore(release): bump version (#2004)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* perf(g-plugin-canvas-renderer): improve wavy text decoration with quadratic curves

* Update __tests__/demos/event/hit-test.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants