-
Notifications
You must be signed in to change notification settings - Fork 1.7k
revert: tooltip logic to 5.2.12 #6776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 1e73769.
This reverts commit 0318b9d.
…ntvis#6717)" This reverts commit 17c5c41.
This reverts commit 4566b64.
Pull Request Test Coverage Report for Build 14443876534Details
💛 - Coveralls |
操作方式是直接按顺序 revert 代码吗?又遇到冲突吗?需要二次检查一下:
|
是找所有含有 tooltip 关键词的 git commit,遇到了一些冲突,但是基本上都是单测文件夹里面的 index.ts 的导出代码的冲突,都已经解决,单测也检测了一遍,没有报错 |
我记得我也提了一个 pr,这个 pr 需要回滚吗?不确定是不是之前你的 pr 带来的问题。 |
把相关的 pr 在描述中加入进去吧,这样可以在信息流中关联起来。 |
回滚背景因为 tooltip 逻辑的贸然修改,导致了后续代码无法正常迭代,出现了 bug 滚雪球的情况,后续 bugfix 不断的在修复之前的 bugfix 导致的坑。特此 revert 5.2.12 - 5.3.0 期间所有的 tooltip 的相关逻辑的修改,从而重新设计最初 issue 的修复思路,维持代码的可持续维护性。 时间线
原因
后续
|
这几个遇到的issue后续可以都加入tooltip的单测,覆盖率提高一点 |
已经对比 https://github.com/antvis/G2/blob/3373ba65a62921db5f5673bde67b55ab5dc755a5/ 的代码, |
* Revert "fix: tooltip pickup error when width is not equal (#6738)" This reverts commit 1e73769. * Revert "fix: tooltip with one element (#6763)" This reverts commit 0318b9d. * Revert "fix(tooltip): handle single element case in series tooltip (#6717)" This reverts commit 17c5c41. * Revert "fix: display abnormally when seriesTooltip (#6708)" This reverts commit 4566b64.
Checklist
npm test
passesDescription of change