Skip to content

fix: memory abnormal caused by tooltip emitter #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Jul 21, 2025

Description of change

ant-design/ant-design-charts#3015

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @lxfu1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve a reported memory abnormality within the tooltip interaction module. The core change involves ensuring that all relevant event listeners, specifically those for tooltip:disable and tooltip:enable events, are correctly detached when the tooltip component is no longer needed, thereby preventing potential memory leaks and improving application stability.

Highlights

  • Memory Leak Fix: Addressed a potential memory anomaly related to the tooltip component by ensuring that tooltip:disable and tooltip:enable event listeners are properly unsubscribed during cleanup.
  • Event Listener Cleanup: Enhanced the event listener cleanup process for the tooltip emitter in src/interaction/tooltip.ts to explicitly detach listeners for tooltip:disable and tooltip:enable events, preventing resource accumulation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a memory leak in the tooltip interaction by ensuring that tooltip:disable and tooltip:enable event listeners are properly removed when the component is destroyed.

@lxfu1 lxfu1 force-pushed the fix/memory-overflow branch from ff47d66 to 4cd8512 Compare July 21, 2025 08:21
@lxfu1 lxfu1 merged commit 3d12604 into v5 Jul 21, 2025
4 of 5 checks passed
@lxfu1 lxfu1 deleted the fix/memory-overflow branch July 21, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants