Add entry priority for applications plugin #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirottu
reviewed
Sep 26, 2025
plugins/applications/src/lib.rs
Outdated
| max_entries: 5, | ||
| preprocess_exec_script: None, | ||
| terminal: None, | ||
| entry_priority: None, |
There was a problem hiding this comment.
Since the default behavior resolves to ActionsFirst, it should be reflected here. That should also be returned by a separate function Config::default_entry_priority or by a sufficient implementation of Default on EntryPriority.
HelloWorld017
force-pushed
the
feature/add-entry-priority
branch
from
460a293 to
3494622
Compare
|
Alright the code looks good now, but at least in my testing the setting didn't actually have any effect (with both the Zen browser and Firefox the main entry appeared first regardless of the priority setting). I think the weights need to be adjusted so that it works like expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new configuration option to sort the entries to the
applicationsplugin.Motivation
#257
Screenshot
With
ActionsFirst:With
ApplicationsFirst: