This repository was archived by the owner on Jan 9, 2020. It is now read-only.
forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 117
Dynamic Executor Scaling #224
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3fa9257
dynamic allocation: shuffle service docker, yaml and test fixture
foxish 0e586fb
dynamic allocation: changes to spark-core
foxish a0f0fa8
dynamic allocation: kubernetes cluster scheduler changes
foxish e8bfbd6
dynamic allocation: tests
foxish 93a1815
dynamic allocation: docs
foxish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| apiVersion: extensions/v1beta1 | ||
| kind: DaemonSet | ||
| metadata: | ||
| labels: | ||
| app: spark-shuffle-service | ||
| spark-version: 2.1.0 | ||
| name: shuffle | ||
| spec: | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: spark-shuffle-service | ||
| spark-version: 2.1.0 | ||
| spec: | ||
| volumes: | ||
| - name: temp-volume | ||
| hostPath: | ||
| path: '/var/tmp' # change this path according to your cluster configuration. | ||
| containers: | ||
| - name: shuffle | ||
| # This is an official image that is built | ||
| # from the dockerfiles/shuffle directory | ||
| # in the spark distribution. | ||
| image: kubespark/spark-shuffle:v2.1.0-kubernetes-0.1.0-alpha.3 | ||
| volumeMounts: | ||
| - mountPath: '/tmp' | ||
| name: temp-volume | ||
| # more volumes can be mounted here. | ||
| # The spark job must be configured to use these | ||
| # mounts using the configuration: | ||
| # spark.kubernetes.shuffle.dir=<mount-1>,<mount-2>,... | ||
| resources: | ||
| requests: | ||
| cpu: "1" | ||
| limits: | ||
| cpu: "1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
...rce-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/Util.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.deploy.kubernetes | ||
|
|
||
| import org.apache.spark.SparkException | ||
|
|
||
| object Util { | ||
| def parseKeyValuePairs( | ||
| maybeKeyValues: Option[String], | ||
| configKey: String, | ||
| keyValueType: String): Map[String, String] = { | ||
|
|
||
| maybeKeyValues.map(keyValues => { | ||
| keyValues.split(",").map(_.trim).filterNot(_.isEmpty).map(keyValue => { | ||
| keyValue.split("=", 2).toSeq match { | ||
| case Seq(k, v) => | ||
| (k, v) | ||
| case _ => | ||
| throw new SparkException(s"Custom $keyValueType set by $configKey must be a" + | ||
| s" comma-separated list of key-value pairs, with format <key>=<value>." + | ||
| s" Got value: $keyValue. All values: $keyValues") | ||
| } | ||
| }).toMap | ||
| }).getOrElse(Map.empty[String, String]) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,6 +157,13 @@ package object config extends Logging { | |
| .stringConf | ||
| .createOptional | ||
|
|
||
| private[spark] val SPARK_SHUFFLE_SERVICE_HOST = | ||
| ConfigBuilder("spark.shuffle.service.host") | ||
| .doc("Host for Spark Shuffle Service") | ||
| .internal() | ||
| .stringConf | ||
| .createOptional | ||
|
|
||
| // Note that while we set a default for this when we start up the | ||
| // scheduler, the specific default value is dynamically determined | ||
| // based on the executor memory. | ||
|
|
@@ -271,6 +278,38 @@ package object config extends Logging { | |
| .stringConf | ||
| .createOptional | ||
|
|
||
| private[spark] val KUBERNETES_SHUFFLE_NAMESPACE = | ||
| ConfigBuilder("spark.kubernetes.shuffle.namespace") | ||
| .doc("Namespace of the shuffle service") | ||
| .stringConf | ||
| .createWithDefault("default") | ||
|
|
||
| private[spark] val KUBERNETES_SHUFFLE_SVC_IP = | ||
| ConfigBuilder("spark.kubernetes.shuffle.ip") | ||
|
||
| .doc("This setting is for debugging only. Setting this " + | ||
| "allows overriding the IP that the executor thinks its colocated " + | ||
| "shuffle service is on") | ||
| .stringConf | ||
| .createOptional | ||
|
|
||
| private[spark] val KUBERNETES_SHUFFLE_LABELS = | ||
| ConfigBuilder("spark.kubernetes.shuffle.labels") | ||
| .doc("Labels to identify the shuffle service") | ||
| .stringConf | ||
| .createOptional | ||
|
|
||
| private[spark] val KUBERNETES_SHUFFLE_DIR = | ||
| ConfigBuilder("spark.kubernetes.shuffle.dir") | ||
| .doc("Path to the shared shuffle directories.") | ||
| .stringConf | ||
| .createOptional | ||
|
|
||
| private[spark] val KUBERNETES_DYNAMIC_ALLOCATION_SIZE = | ||
| ConfigBuilder("spark.kubernetes.dynamic.allocation.size") | ||
| .doc("Number of pods to launch at once in each round of dynamic allocation.") | ||
| .intConf | ||
| .createWithDefault(5) | ||
|
|
||
| private[spark] val DRIVER_SERVICE_MANAGER_TYPE = | ||
| ConfigBuilder("spark.kubernetes.driver.serviceManagerType") | ||
| .doc("A tag indicating which class to use for creating the Kubernetes service and" + | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new configuration you are introducing? We will need documentation for this for sure to know what is this for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please use the
ConfigBuilderfromconfig.scalaand its.internal()marker if this is not meant to be set by users and is only used internally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ash211 do you think we should add it into spark-core alongside
spark.shuffle.service.portthat already exists there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the configbuilder for references to
spark.shuffle.service.hostwithin the Kubernetes package; and left it as it is here, conforming to the surrounding code in spark-core.