This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Fix watcher conditional logic #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anybody else getting build fail? It's failing in core, which this PR makes no changes to. |
|
jenkins please test this |
|
rerun unit tests please |
|
@erikerlandson I think it's a flake. The rerun should fix it. |
|
Do these edits look OK to everyone else? |
|
Taking a look now. Sorry about the delay. |
|
I think |
ash211
approved these changes
May 10, 2017
| extends Watcher[Service] { | ||
| override def eventReceived(action: Action, service: Service): Unit = { | ||
| if ((action == Action.ADDED) || (action == Action.MODIFIED) | ||
| if ((action == Action.ADDED || action == Action.MODIFIED) |
There was a problem hiding this comment.
the parentheses change slightly modifies the evaluation order of these expressions, and the new ordering seems correct.
Java precedence for boolean expressions is ! then && then || so previously this was evaluating the && first and then the ||
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
…nc-kube [NOSQUASH] Resync with Kubernetes
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some exceptions being thrown from the endpoint watcher in the submission client. It turned out that
nullvalues were being returned forendpoints.getSubsets, instead of just empty collection. I added some guarding checks fornull, which fixed the problem.I also modified the parentheses around action types, because that appeared incorrect. I believe it should be checking for
(action == added || action == modified)as a unit in the first clause.