GH-721: Allow using 1GB+ data buffers in variable width vectors #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow actually reaching MAX_BUFFER_SIZE at reallocating variable width vectors instead of exceeding it calculating the next power of 2.
gszadovszky
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
lidavidm
reviewed
Apr 22, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Is it possible to write a test for this?
Contributor
Author
I think we already have tests related to reallocation. The contract of the related methods did not change related to this change. Do you think we still need to test that we are allocating between 1GB and 2GB? BTW, do you know what the actual failure is about "Ensure PR format"? |
Member
|
You can ignore that check for now. I ask because previously allocating between 1 and 2 GB didn't work, so a regression test would be useful to provide. |
Contributor
Author
|
@lidavidm added a unit test. Let's see if the decreasing of the default max allocation size by 1 byte would cause any harm in the other tests. |
Contributor
Author
|
Thank you, @lidavidm! |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
May 15, 2025
### What changes were proposed in this pull request? This pr aims to upgrade `arrow-java` from 18.2.0 to 18.3.0. ### Why are the changes needed? The new version bring some bug fixes, like: - apache/arrow-java#627 - apache/arrow-java#654 - apache/arrow-java#656 - apache/arrow-java#693 - apache/arrow-java#705 - apache/arrow-java#707 - apache/arrow-java#722 In addition, the new version introduces a cascading upgrade for flatbuffers-java([ from 24.3.25 to 25.1.24 ](apache/arrow-java#600)) the full release note as follows: - https://github.com/apache/arrow-java/releases/tag/v18.3.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Acitons ### Was this patch authored or co-authored using generative AI tooling? No Closes #50892 from LuciferYang/arrow-java-18.3.0. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? This pr aims to upgrade `arrow-java` from 18.2.0 to 18.3.0. ### Why are the changes needed? The new version bring some bug fixes, like: - apache/arrow-java#627 - apache/arrow-java#654 - apache/arrow-java#656 - apache/arrow-java#693 - apache/arrow-java#705 - apache/arrow-java#707 - apache/arrow-java#722 In addition, the new version introduces a cascading upgrade for flatbuffers-java([ from 24.3.25 to 25.1.24 ](apache/arrow-java#600)) the full release note as follows: - https://github.com/apache/arrow-java/releases/tag/v18.3.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Acitons ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50892 from LuciferYang/arrow-java-18.3.0. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 3, 2025
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 3, 2025
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 3, 2025
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 3, 2025
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 3, 2025
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 10, 2025
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 10, 2025
timhurskidremio
added a commit
to dremio/arrow
that referenced
this pull request
Nov 10, 2025
timhurskidremio
added a commit
to dremio/arrow
that referenced
this pull request
Nov 10, 2025
timhurskidremio
added a commit
to dremio/arrow
that referenced
this pull request
Nov 10, 2025
timhurskidremio
added a commit
to dremio/arrow
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Allow actually reaching MAX_BUFFER_SIZE at reallocating variable width vectors instead of exceeding it calculating the next power of 2.
For unit testing the maximum allocation size has be increased to 2MB - 1byte to simulate the default maximum behavior. Due to this change needed some updates in existing unit tests because of the round ups used at calculating the required buffer sizes.
Closes #721.