[Variant] Rename `batch_json_string_to_variant` and `batch_variant_to_json_string` json_to_variant

[alamb]

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

• While working on examples in Add variant_experimental feature to parquet crate #8133
  I found the names of batch_json_string_to_variant and batch_variant_to_json_string were akward:

1. They are very long
2. They use terminology (like batch and string) that is not common in the arrow/parquet crates

Describe the solution you'd like
I would like to name the functions with shorter names that are more consistent with the rest of the crate

Describe alternatives you've considered
I propose

• batch_json_string_to_variant --> json_to_variant
• batch_variant_to_json_string --> variant_to_json

Additional context

[liamzwbao]

take

[liamzwbao]

Hi @alamb, I found that we already have json_to_variant and variant_to_json in parquet_variant_json so I guess we still need something like batch_json_to_variant and batch_variant_to_json to differentiate between them. Batch may not a good prefix tho, do you have any suggestions?

[alamb]

Hi @alamb, I found that we already have json_to_variant and variant_to_json in parquet_variant_json so I guess we still need something like batch_json_to_variant and batch_variant_to_json to differentiate between them. Batch may not a good prefix tho, do you have any suggestions?

Since I expect the batch version (that operates on arrays to be more common) how about adding a _value suffix to the existing ones and then taking the variant_to_json and json_to_variant names?

• json_to_variant --> json_to_variant_value
• variant_to_json --> variant_to_json_value

Another thing we could do is add an extension trait like this instead of json_to_variant and variant_to_json 🤔

pub trait VariantToJson {
  fn to_json(&self) -> Json::Value;
  fn from_json(value: Json::Value) --> Self;
}

[alamb]

label_issue.py automatically added labels {'parquet'} from #8133