Skip to content

fix clippy errors in 1.60 #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix clippy errors in 1.60 #1527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arrow/src/ffi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ impl Drop for FFI_ArrowSchema {

// returns the number of bits that buffer `i` (in the C data interface) is expected to have.
// This is set by the Arrow specification
#[allow(clippy::manual_bits)]
fn bit_width(data_type: &DataType, i: usize) -> Result<usize> {
Ok(match (data_type, i) {
// the null buffer is bit sized
Expand Down
4 changes: 4 additions & 0 deletions parquet/src/arrow/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,7 @@ impl ParquetTypeConverter<'_> {
}
}

#[allow(clippy::wrong_self_convention)]
fn from_int32(&self) -> Result<DataType> {
match (
self.schema.get_basic_info().logical_type(),
Expand Down Expand Up @@ -707,6 +708,7 @@ impl ParquetTypeConverter<'_> {
}
}

#[allow(clippy::wrong_self_convention)]
fn from_int64(&self) -> Result<DataType> {
match (
self.schema.get_basic_info().logical_type(),
Expand Down Expand Up @@ -758,6 +760,7 @@ impl ParquetTypeConverter<'_> {
}
}

#[allow(clippy::wrong_self_convention)]
fn from_fixed_len_byte_array(&self) -> Result<DataType> {
match (
self.schema.get_basic_info().logical_type(),
Expand Down Expand Up @@ -796,6 +799,7 @@ impl ParquetTypeConverter<'_> {
)
}

#[allow(clippy::wrong_self_convention)]
fn from_byte_array(&self) -> Result<DataType> {
match (self.schema.get_basic_info().logical_type(), self.schema.get_basic_info().converted_type()) {
(Some(LogicalType::STRING(_)), _) => Ok(DataType::Utf8),
Expand Down