Skip to content

Implement Eq for ScalarBuffer when T: Eq #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Implement Eq for ScalarBuffer when T: Eq #7412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af4b764
Implement Eq for ScalarBuffer when possible
emilk Apr 14, 2025
f35920c
fix typo
emilk Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions arrow-buffer/src/buffer/scalar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ impl<T: ArrowNativeType> PartialEq<ScalarBuffer<T>> for Vec<T> {
}
}

/// If T implements Eq, then so does ScalarBuffer.
impl<T: ArrowNativeType + Eq> Eq for ScalarBuffer<T> {}

#[cfg(test)]
mod tests {
use std::{ptr::NonNull, sync::Arc};
Expand Down Expand Up @@ -342,4 +345,19 @@ mod tests {
assert_eq!(vec, input.as_slice());
assert_ne!(vec.as_ptr(), input.as_ptr());
}

#[test]
fn scalar_buffer_impl_eq() {
fn are_equal<T: Eq>(a: &T, b: &T) -> bool {
a.eq(b)
}

assert!(
are_equal(
&ScalarBuffer::<i16>::from(vec![23]),
&ScalarBuffer::<i16>::from(vec![23])
),
"ScalarBuffer should implement Eq if the inner type does"
);
}
}
Loading