Skip to content

Implement Default for Buffer & ScalarBuffer #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

Implement Default for Buffer & ScalarBuffer #7413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
244e9b0
Implement `Default` for `ScalarBuffer`
emilk Apr 14, 2025
abb6498
`impl Default for Buffer`
emilk Apr 14, 2025
b97c042
Auto-derive Default
emilk Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions arrow-buffer/src/buffer/immutable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ pub struct Buffer {
length: usize,
}

impl Default for Buffer {
#[inline]
fn default() -> Self {
MutableBuffer::default().into()
}
}

impl PartialEq for Buffer {
fn eq(&self, other: &Self) -> bool {
self.as_slice().eq(other.as_slice())
Expand Down
2 changes: 1 addition & 1 deletion arrow-buffer/src/buffer/scalar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ use std::ops::Deref;
/// let sliced = buffer.slice(1, 2);
/// assert_eq!(&sliced, &[2, 3]);
/// ```
#[derive(Clone)]
#[derive(Clone, Default)]
pub struct ScalarBuffer<T: ArrowNativeType> {
/// Underlying data buffer
buffer: Buffer,
Expand Down
Loading