arrow: add concat structs benchmark #7520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 16, 2025
asubiotto
force-pushed
the
asubiotto-structbench
branch
from
b939cfe to
3f8b828
Compare
|
Running these benchmarks on the other PR I realized I made the int32 values slice as large as the dictionary length. Changed it from 1024 to 20 distinct values out of 1024 to be more realistic. |
asubiotto
force-pushed
the
asubiotto-structbench
branch
from
3f8b828 to
f74a0de
Compare
|
Further reduced the verbosity of the benchmark and parametrized batch size + count since I found it useful to tweak these in #7519 |
asubiotto
force-pushed
the
asubiotto-structbench
branch
from
f74a0de to
24cf67d
Compare
alamb
reviewed
May 16, 2025
| }) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| let array_refs = struct_arrays |
There was a problem hiding this comment.
this is a really annoying part of the concat API
|
Let's get this one in and we can iterate on it once merged |
|
Thanks again @asubiotto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A struct concatenation benchmark was requested in #7517 (review)
What changes are included in this PR?
This PR creates a struct with a primitive field, and two sparse dictionary fields (one primitive, one utf8) and benchmarks concatenation.